Use load_array_ref to implement from_slice
#184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenzV
approved these changes
Jan 22, 2026
Collaborator
|
Perhaps this will fix our issues with #171! |
Contributor
|
This fixed much of my issues with QuState/PhastFT#58 ! There's still a performance gap vs wide but this closes much of it! |
Collaborator
|
How much is left? |
Contributor
|
On x86 (Zen4) it ranges from on par to 6% worse but that's not perfectly apples-to-apples since Zen4 has AVX-512 (emulated, double-pumped) that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I meant to use this method to implement the
from_slicemethod, but apparently usedload_arrayinstead.